Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 1801 develop plot tcmpr #1806

Merged
merged 2 commits into from
May 21, 2021
Merged

Bugfix 1801 develop plot tcmpr #1806

merged 2 commits into from
May 21, 2021

Conversation

bikegeek
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

-on 'kiowa':

  1. Clone the task_1801_dev_plot_tcmpr branch (to merge into develop branch)
  2. Create a $MET_INSTALL_DIR/share/met/Rscripts directory
  3. copy all the scripts in $SRC_DIR/MET/met/scripts/Rscripts into $MET_INSTALL_DIR/share/met/Rscripts
  4. Set MET_INSTALL_DIR env variable
  5. Run the following: Rscript $MET_INSTALL_DIR/share/met/Rscripts/plot_tcmpr.R -config /home/minnawin/METplus/parm/use_cases/model_applications/tc_and_extra_tc/Plotter_fcstGFS_obsGFS_RPlotting/TCMPRPlotterConfig_customize -lookin /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.gfso.0002.tcst /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.emx.0002.tcst /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.cmc.0002.tcst -outdir /home/minnawin/met-help/99800/output/tcmpr_plots -no_ee -dep AMSLP-BMSLP,TK_ERR -plot MEAN,MEDIAN
  6. cd to the -outdir specified above and verify that mean and median plots are generated, with points for all three models: GFSO, EMX, and CMC on each plot.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    • repeat the steps above, replacing $MET_INSTALL_DIR and $SRC_DIR to reflect your environment

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [ No]

  • Do these changes include sufficient testing updates? [ No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [06/02/2021].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek
Github Issue #1801: Comment out code that checks for BEST track to su…
c2ab531 
…pport extra-tropical cyclone tracks not verified against BEST tracks.
@bikegeek
Gitub Issue #1801 Remove code that checks for -bmodel filter to suppo…
7a88a83 
…rt plotting of extra-tropical cyclone tracks that aren't verified against BEST tracks.
@bikegeek bikegeek added this to the MET 10.1.0 milestone May 21, 2021
@JohnHalleyGotway JohnHalleyGotway changed the base branch from main_v10.0 to develop May 21, 2021 17:45
@JohnHalleyGotway JohnHalleyGotway changed the title Task 1801 dev plot tcmpr Bugfix 1801 develop plot tcmpr May 21, 2021
@JohnHalleyGotway JohnHalleyGotway linked an issue May 21, 2021 that may be closed by this pull request
Fix the plot_tcmpr.R script to plot extra-tropical cyclone tracks not verified against BEST tracks. #1801
Closed
21 tasks
JohnHalleyGotway
JohnHalleyGotway approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched the base branch from main_v10.0 to develop, modified the name to match the bugfix PR issue template, added a link to the source #1801, and reviewed the change.

Looks fine to me.

I approve of this change.

@bikegeek bikegeek merged commit 385088d into develop May 21, 2021
@bikegeek bikegeek deleted the task_1801_dev_plot_tcmpr branch May 21, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MET 10.1.0
Development

Successfully merging this pull request may close these issues.

Fix the plot_tcmpr.R script to plot extra-tropical cyclone tracks not verified against BEST tracks.
2 participants
@bikegeek @JohnHalleyGotway